Merged
Conversation
gregwinterstein
force-pushed
the
fix/341-odata-cli-ignore-exclude-schema-types
branch
from
805c25e to
4736b39
Compare
ElizabethOkerio
requested review from
ElizabethOkerio,
KenitoInc,
gathogojr and
habbes
Contributor
Author
@habbes The current tests for the command-line are marked as |
KenitoInc
approved these changes
Aug 11, 2023
Contributor
|
@gregwinterstein Can you rebase the PR? |
gregwinterstein
force-pushed
the
fix/341-odata-cli-ignore-exclude-schema-types
branch
from
4736b39 to
5484bc3
Compare
Contributor
Author
@KenitoInc I have rebased the pull request as requested. |
gregwinterstein
added a commit
to gregwinterstein/ODataConnectedService
that referenced
this pull request
Aug 22, 2023
gathogojr
pushed a commit
to gregwinterstein/ODataConnectedService
that referenced
this pull request
Sep 25, 2023
gregwinterstein
added a commit
to gregwinterstein/ODataConnectedService
that referenced
this pull request
Oct 2, 2023
gregwinterstein
added a commit
to gregwinterstein/ODataConnectedService
that referenced
this pull request
Mar 11, 2024
gregwinterstein
added a commit
to gregwinterstein/ODataConnectedService
that referenced
this pull request
Mar 26, 2024
gregwinterstein
deleted the
fix/341-odata-cli-ignore-exclude-schema-types
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #341 the
exclude-schema-typesoption (and other exclusion options) are ignored by the odata-cli.This is because the option is described as a comma-separated list but implemented as a list.
This change converts the exclusion options into strings and splits the strings on commas when passing the exclusions into the generators.
This fixes issue #341