Skip to content

Fix missing ContainerProperty attribute on dynamic properties (issue #380) #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
habbes merged 4 commits into from
Mar 26, 2024
Merged

Fix missing ContainerProperty attribute on dynamic properties (issue #380) #381

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
00e0b8d
fix version comparison
stanb-semperis Mar 5, 2024
c9c79bb
greater then 7.6.4.0
stanb Mar 5, 2024
5a4e8a7
Revert "greater then 7.6.4.0"
stanb-semperis Mar 23, 2024
99b5a91
fix version
stanb-semperis Mar 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ODataConnectedService.Shared/ConnectedServiceFileHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ public bool EmitContainerPropertyAttribute()
if (reference.SourceProject == null)
{
// Assembly reference (For project reference, SourceProject != null)
if (reference.Name.Equals("Microsoft.OData.Client", StringComparison.Ordinal) && string.Compare(reference.Version, "7.6.4.0", StringComparison.Ordinal) > 0)
if (reference.Name.Equals("Microsoft.OData.Client", StringComparison.Ordinal))
{
return true;
return Version.Parse(reference.Version) > Version.Parse("7.6.4.0");
Copy link
Copy Markdown
Contributor

@ElizabethOkerio ElizabethOkerio Mar 25, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a parsing exception here? or reference.Version will always be in the required format?

Copy link
Copy Markdown
Contributor

@gathogojr gathogojr Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Especially because the reference is for a library we maintain, plus this statement is in within the block

if (reference.Name.Equals("Microsoft.OData.Client", StringComparison.Ordinal))

I think this should be safe.
In addition, we currently update the Microsoft.OData.Client reference manually.

}
}
}
Expand Down