ODL9: Cherry-pick - Add ShouldReadPropertyAsStream API to allow access to property annotations#3488
Open
WanjohiSammy wants to merge 2 commits intodev-9.xfrom
Open
Conversation
…tions (#3477) * Add ShouldReadPropertyAsStream and depracate ReadAsStreamFunc --------- Co-authored-by: John Gathogo <john.gathogo@gmail.com>
Member
Author
|
/AzurePipelines run |
1 similar comment
Member
Author
|
/AzurePipelines run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
Member
Author
|
/AzurePipelines run |
1 similar comment
Member
Author
|
/AzurePipelines run |
WanjohiSammy
force-pushed
the
cherrypick/2f80bcedc36e05b2d68f9dfa484643ec62a6d89b
branch
from
2492cf6 to
d27fc46
Compare
Member
Author
|
/AzurePipelines run |
xuzhg
reviewed
Jan 20, 2026
| ODataPropertyStreamingContext propertyReadingContext = new ODataPropertyStreamingContext | ||
| { | ||
| PrimitiveType = primitiveType, | ||
| IsCollection = false, |
Member
There was a problem hiding this comment.
IsCollection, PropertyName ... are hardcoded, It seems no sense?
We don't have the IEdmProperty for the declared property reading?
xuzhg
reviewed
Jan 20, 2026
| [Obsolete("Use 'ShouldReadPropertyAsStream' instead, which provides access to property annotations. ReadAsStreamFunc will be removed in a future ODL 9 release.")] | ||
| public Func<IEdmPrimitiveType, bool, string, IEdmProperty, bool> ReadAsStreamFunc { get; set; } | ||
|
|
||
| /// <summary> |
Member
There was a problem hiding this comment.
Can we consider to make it as a service into the DI?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
This pull request fixes #xxx.
Description
Cherry-pick: fad37ae
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.
Repository notes
Team members can start a CI build by adding a comment with the text
/AzurePipelines runto a PR. A bot may respond indicating that there is no pipeline associated with the pull request. This can be ignored if the build is triggered.Team members should not trigger a build this way for pull requests coming from forked repositories. They should instead trigger the build manually by setting the "branch" to
refs/pull/{prId}/mergewhere{prId}is the ID of the PR.