Handle status code Uncertain according to the specification#2898
Merged
mrsuciu merged 2 commits intoOPCFoundation:masterfrom Dec 17, 2024
larws:bug/status-code-uncertain
Merged
Handle status code Uncertain according to the specification#2898mrsuciu merged 2 commits intoOPCFoundation:masterfrom larws:bug/status-code-uncertain
mrsuciu merged 2 commits intoOPCFoundation:masterfrom
larws:bug/status-code-uncertain
Conversation
When a method state's call method is invoked the output arguments should be written in case the status code is good or uncertain. This behavior would be conform with the current specification.
The result of the Call method in the CustomNodeManager2 class represents the status of the CallMethodResult. It does not correspond to the ServiceResult of the CallResponse, thus returning Good as a general response is incorrect behavior.
mregen
approved these changes
Dec 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2898 +/- ##
=======================================
Coverage 55.43% 55.44%
=======================================
Files 352 352
Lines 67602 67605 +3
Branches 13849 13851 +2
=======================================
+ Hits 37477 37483 +6
Misses 26021 26021
+ Partials 4104 4101 -3 ☔ View full report in Codecov by Sentry. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
@larws please sign the contributor agreement |
Contributor
Author
mrsuciu
approved these changes
Dec 17, 2024
Contributor
mregen
pushed a commit
that referenced
this pull request
Jan 8, 2025
* #2896: Write output arguments for good and uncertain status code When a method state's call method is invoked the output arguments should be written in case the status code is good or uncertain. This behavior would be conform with the current specification. * #2896: The service result corresponds the method call result The result of the Call method in the CustomNodeManager2 class represents the status of the CallMethodResult. It does not correspond to the ServiceResult of the CallResponse, thus returning Good as a general response is incorrect behavior.
13 tasks
mregen
added a commit
that referenced
this pull request
Jan 17, 2025
* Some cleanup of the new APIs and Union implementation. * fix build * Handle status code Uncertain according to the specification (#2898) * #2896: Write output arguments for good and uncertain status code When a method state's call method is invoked the output arguments should be written in case the status code is good or uncertain. This behavior would be conform with the current specification. * #2896: The service result corresponds the method call result The result of the Call method in the CustomNodeManager2 class represents the status of the CallMethodResult. It does not correspond to the ServiceResult of the CallResponse, thus returning Good as a general response is incorrect behavior. * Add SetHiResClockDisabled & fix Rejected Store Creation in ApplicationConfigurationBuilder (#2909) Add the method SetHiResClockDisabled to IApplicationConfigurationBuilder Fix the type of RejectedStore Created by the Builder to: CertificateStoreIdentifier * revert based on feedback * move some logic from class code to encoder/decoder * Fix race condition on Nuget build (#2930) - nodeset xmlzip is created in obj folders if multiple targets are built in parallel
mrsuciu
pushed a commit
that referenced
this pull request
Mar 7, 2025
* Add missing constants for JSON encoding. * Update generated files to 1.05.04. * Update NuGets * Fix compile errors due to abstract types. * Update nodesets. * Update JSON Encoder/Decoder. * Update with JSON encoder. * Change prefix char. * Change prefix to uppercase. * Fix JsonEncoder * Fix null pointer. * Update encoders to suppress artifacts. * JSON encoding fixes. * Fix JSON RawEncoding * Update JSON encoders. * Revert changes for Matrix in Variant. * Update NodeSet. * Resolve name conflict with new Opc.Ua types. * Fix failing Tests * Fix unit tests after change to Verbose/Compact encoding. * Add final 1.05.04 generated classes and unit test fixes. * Fix more unit tests. * Update NodeSet to released version. * Remove unintended changes to UANodeSet.xsd * Update Schema/UANodeSet.xsd * Merge breaking changes to JsonEncoder.cs from develop/main374 * Allow JObject in ExtensionObjects. * fix version json * Update generated files to UA-1.05.04-2025-01-08 * Some cleanup of the new APIs and Union implementation. (#2927) * Some cleanup of the new APIs and Union implementation. * fix build * Handle status code Uncertain according to the specification (#2898) * #2896: Write output arguments for good and uncertain status code When a method state's call method is invoked the output arguments should be written in case the status code is good or uncertain. This behavior would be conform with the current specification. * #2896: The service result corresponds the method call result The result of the Call method in the CustomNodeManager2 class represents the status of the CallMethodResult. It does not correspond to the ServiceResult of the CallResponse, thus returning Good as a general response is incorrect behavior. * Add SetHiResClockDisabled & fix Rejected Store Creation in ApplicationConfigurationBuilder (#2909) Add the method SetHiResClockDisabled to IApplicationConfigurationBuilder Fix the type of RejectedStore Created by the Builder to: CertificateStoreIdentifier * revert based on feedback * move some logic from class code to encoder/decoder * Fix race condition on Nuget build (#2930) - nodeset xmlzip is created in obj folders if multiple targets are built in parallel * update common comments * Update NodeSet files. * Fix ReadSwitchField Implementation. * Make UserIdentity.DisplayName writeable. * Fix merge failures. * Fix XmlElement encoding and bad NamespaceIndex fallback logic. * Fix 2D array raw encoding. * Add support for DesignToolOnly. --------- Co-authored-by: Randy Armstrong <randy@sparhawksoftware.com> Co-authored-by: Martin Regen <mregen@microsoft.com> Co-authored-by: Martin Regen <7962757+mregen@users.noreply.github.com>
mregen
added a commit
to mregen/UA-.NetStandard
that referenced
this pull request
Mar 18, 2025
* Add missing constants for JSON encoding. * Update generated files to 1.05.04. * Update NuGets * Fix compile errors due to abstract types. * Update nodesets. * Update JSON Encoder/Decoder. * Update with JSON encoder. * Change prefix char. * Change prefix to uppercase. * Fix JsonEncoder * Fix null pointer. * Update encoders to suppress artifacts. * JSON encoding fixes. * Fix JSON RawEncoding * Update JSON encoders. * Revert changes for Matrix in Variant. * Update NodeSet. * Resolve name conflict with new Opc.Ua types. * Fix failing Tests * Fix unit tests after change to Verbose/Compact encoding. * Add final 1.05.04 generated classes and unit test fixes. * Fix more unit tests. * Update NodeSet to released version. * Remove unintended changes to UANodeSet.xsd * Update Schema/UANodeSet.xsd * Merge breaking changes to JsonEncoder.cs from develop/main374 * Allow JObject in ExtensionObjects. * fix version json * Update generated files to UA-1.05.04-2025-01-08 * Some cleanup of the new APIs and Union implementation. (OPCFoundation#2927) * Some cleanup of the new APIs and Union implementation. * fix build * Handle status code Uncertain according to the specification (OPCFoundation#2898) * OPCFoundation#2896: Write output arguments for good and uncertain status code When a method state's call method is invoked the output arguments should be written in case the status code is good or uncertain. This behavior would be conform with the current specification. * OPCFoundation#2896: The service result corresponds the method call result The result of the Call method in the CustomNodeManager2 class represents the status of the CallMethodResult. It does not correspond to the ServiceResult of the CallResponse, thus returning Good as a general response is incorrect behavior. * Add SetHiResClockDisabled & fix Rejected Store Creation in ApplicationConfigurationBuilder (OPCFoundation#2909) Add the method SetHiResClockDisabled to IApplicationConfigurationBuilder Fix the type of RejectedStore Created by the Builder to: CertificateStoreIdentifier * revert based on feedback * move some logic from class code to encoder/decoder * Fix race condition on Nuget build (OPCFoundation#2930) - nodeset xmlzip is created in obj folders if multiple targets are built in parallel * update common comments * Update NodeSet files. * Fix ReadSwitchField Implementation. * Make UserIdentity.DisplayName writeable. * Fix merge failures. * Fix XmlElement encoding and bad NamespaceIndex fallback logic. * Fix 2D array raw encoding. * Add support for DesignToolOnly. --------- Co-authored-by: Randy Armstrong <randy@sparhawksoftware.com> Co-authored-by: Martin Regen <mregen@microsoft.com> Co-authored-by: Martin Regen <7962757+mregen@users.noreply.github.com>
mregen
added a commit
to mregen/UA-.NetStandard
that referenced
this pull request
Mar 21, 2025
* Add missing constants for JSON encoding. * Update generated files to 1.05.04. * Update NuGets * Fix compile errors due to abstract types. * Update nodesets. * Update JSON Encoder/Decoder. * Update with JSON encoder. * Change prefix char. * Change prefix to uppercase. * Fix JsonEncoder * Fix null pointer. * Update encoders to suppress artifacts. * JSON encoding fixes. * Fix JSON RawEncoding * Update JSON encoders. * Revert changes for Matrix in Variant. * Update NodeSet. * Resolve name conflict with new Opc.Ua types. * Fix failing Tests * Fix unit tests after change to Verbose/Compact encoding. * Add final 1.05.04 generated classes and unit test fixes. * Fix more unit tests. * Update NodeSet to released version. * Remove unintended changes to UANodeSet.xsd * Update Schema/UANodeSet.xsd * Merge breaking changes to JsonEncoder.cs from develop/main374 * Allow JObject in ExtensionObjects. * fix version json * Update generated files to UA-1.05.04-2025-01-08 * Some cleanup of the new APIs and Union implementation. (OPCFoundation#2927) * Some cleanup of the new APIs and Union implementation. * fix build * Handle status code Uncertain according to the specification (OPCFoundation#2898) * OPCFoundation#2896: Write output arguments for good and uncertain status code When a method state's call method is invoked the output arguments should be written in case the status code is good or uncertain. This behavior would be conform with the current specification. * OPCFoundation#2896: The service result corresponds the method call result The result of the Call method in the CustomNodeManager2 class represents the status of the CallMethodResult. It does not correspond to the ServiceResult of the CallResponse, thus returning Good as a general response is incorrect behavior. * Add SetHiResClockDisabled & fix Rejected Store Creation in ApplicationConfigurationBuilder (OPCFoundation#2909) Add the method SetHiResClockDisabled to IApplicationConfigurationBuilder Fix the type of RejectedStore Created by the Builder to: CertificateStoreIdentifier * revert based on feedback * move some logic from class code to encoder/decoder * Fix race condition on Nuget build (OPCFoundation#2930) - nodeset xmlzip is created in obj folders if multiple targets are built in parallel * update common comments * Update NodeSet files. * Fix ReadSwitchField Implementation. * Make UserIdentity.DisplayName writeable. * Fix merge failures. * Fix XmlElement encoding and bad NamespaceIndex fallback logic. * Fix 2D array raw encoding. * Add support for DesignToolOnly. --------- Co-authored-by: Randy Armstrong <randy@sparhawksoftware.com> Co-authored-by: Martin Regen <mregen@microsoft.com> Co-authored-by: Martin Regen <7962757+mregen@users.noreply.github.com>
mregen
pushed a commit
to mregen/UA-.NetStandard
that referenced
this pull request
Dec 7, 2025
…ation#2898) * OPCFoundation#2896: Write output arguments for good and uncertain status code When a method state's call method is invoked the output arguments should be written in case the status code is good or uncertain. This behavior would be conform with the current specification. * OPCFoundation#2896: The service result corresponds the method call result The result of the Call method in the CustomNodeManager2 class represents the status of the CallMethodResult. It does not correspond to the ServiceResult of the CallResponse, thus returning Good as a general response is incorrect behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
If a method call returns Uncertain as a status code the output arguments values should be set as specified in the specification.
Related Issues
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply. You can also fill these out after creating the PR.Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...