Genesis Transactions

[muraca]

This PR introduces genesis transactions, which are neither validated nor executed.
They are stored in the genesis block, and their outputs are saved in storage as well.
Resolves #107 and blocks #128

Changelog:

• Added std-gated function InherentHooks::genesis_transactions to generate genesis inherents.
• GenesisConfig's only parameter is now a Vec<Transaction>.
• Created file tuxedo-core/src/genesis.rs which contains:
  • A custom TuxedoGenesisBlockBuilder based on the one I implemented in GenesisBuilder with extrinsics execution #123, which reads the extrinsics list from storage key EXTRINSICS_KEY, to include them in the genesis block.
  • The std-gated function assimilate_storage, which:
    • stores the whole genesis_transactions list after the key EXTRINSICS_KEY;
    • checks that the Transactions have no inputs or peeks;
    • the Outputs of the genesis_transactions are stored based on the Transaction that created them.
• The function <TuxedoGenesisConfig as BuildStorage>::assimilate_storage:
  • builds the actual genesis_transactions list appending at InherentHooks::genesis_transactions its TuxedoGenesisConfig.genesis_transactions, since the inherents should appear at the beginning of the block;
  • calls genesis.rs/assimilate_storage;
  • is later called by the TuxedoGenesisBlockBuilder using the trait BuildStorage.
• Updated wallet's initialization and synchronization to work with the new genesis blocks.

[muraca]

Quick recap of what happens:

• The function initially called InherentHooks::genesis_utxos was changed to InherentHooks::genesis_transactions.
• GenesisConfig's only parameter is now a Vec<Transaction>.
• In the std-gated function <GenesisConfig as BuildStorage>::assimilate_storage, which is later called by the GenesisBuilder:
  • the genesis_transactions is appended at the result of InherentHooks::genesis_transactions, since the inherents should appear at the beginning of the block;
  • the whole genesis_transactions list is stored after the key EXTRINSICS_KEY;
  • the Outputs are stored based on the Transaction that created them.
• A custom TuxedoGenesisBlockBuilder based on the one I implemented in GenesisBuilder with extrinsics execution #123 is used instead of the default one, which:
  • is currently stored in crate node, but I think the tuxedo-core would be a better fit;
  • reads the extrinsics list from storage, to include them in the genesis block;
  • currently does not clear the storage item for the key EXTRINSICS_KEY; a temporary fix was put in the Executive code here, to clear the storage before adding the extrinsics for the next block.

[muraca]

@JoshOrndorff I think the init_from_genesis function in the wallet is superfluous, as we can synchronize using the same function we use for all the other blocks. The wallet test fails because this function fails, and if you remove that call, everything works as expected.
I'm not 100% familiar with the wallet yet, so I'll wait for your response on that.

[JoshOrndorff]

Seems like a good time to resolve these. I think any example from any other piece would be sufficient. So maybe add a single PoE claim to genesis block, or a single amoeba creation to the genesis block.

[JoshOrndorff]

I just found out there is some ongoing issue in Substrate about genesis block builder and genesis config and chain spec and how to do it after the native runtime is deprecated.

paritytech/polkadot-sdk#25

[muraca]

@JoshOrndorff

I just found out there is some ongoing issue in Substrate about genesis block builder and genesis config and chain spec and how to do it after the native runtime is deprecated.

paritytech/polkadot-sdk#25

I'd say let's conclude what we have going on now, and later adhere to the new native runtime free standards when everything is finished and well documented.

[JoshOrndorff]

Nice work! This is a next-level job. These traits are not well explored or documented. Cool that we made it work.

[JoshOrndorff]

Partially resolves #107, we should open another issue to try to execute the transactions later on.

I'm not sure executing them adds much value. This happens only at chain launch time, and I think that looking carefully at the genesis block (especially now that it explicitly contains all genesis state) is the duty of someone wanting to use the chain. Basically I'm arguing that the genesis block is like a summary of the prehistory and it's okay if the semantics are squishy or manually enforced for this one-time process to launch the chain.

So IMO this resolves #107 fully.

[github-actions]

Coverage after merging inherent-genesis-utxos into main will be

64.52%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
tuxedo-core/aggregator/src
lib.rs	99.29%	100%	100%	99.26%	117, 21
tuxedo-core/no_bound/src
clone_no_bound.rs	36.63%	100%	30%	37.36%	24, 32–39, 56, 59–72, 74–87, 89, 91–95, 98–99
debug_no_bound.rs	32.73%	100%	30%	33%	101–105, 108–109, 24, 32–42, 58, 60–78, 80–95, 97–99
default_no_bound.rs	19.11%	100%	16.67%	19.31%	100–122, 124–131, 133, 136–147, 151–157, 32–39, 51, 54–80, 83–88, 91–99
lib.rs	100%	100%	100%	100%
tuxedo-core/src
constraint_checker.rs	50%	100%	47.37%	50.75%	110, 71–91, 93–95
dynamic_typing.rs	84.03%	100%	72.73%	88.37%	57
executive.rs	91.52%	100%	92.68%	91.38%	116, 142, 175, 207, 220–228, 236, 247, 298, 325, 376–381, 383, 393–394, 399–400, 403, 405–406, 409–410, 412, 416–437, 439, 443–444, 446–447, 449, 452–469, 54
genesis.rs	30.43%	100%	33.33%	30.30%	114, 36–49, 60, 62–65, 67–68, 70–72, 75–79, 81–83, 85–97
inherents.rs	7.41%	100%	12.50%	6.52%	120–122, 158–159, 164–178, 180–203, 212–217, 219–228, 230, 56–58, 63–68, 70–78, 81, 83
types.rs	70.21%	100%	54.35%	75.35%	13, 143, 36, 86, 88–91, 93–99
utxo_set.rs	90.91%	100%	100%	88.89%	39–40
verifier.rs	87.16%	100%	71.60%	91.05%	120, 154, 28, 54–55, 68
tuxedo-template-runtime/src
lib.rs	33.64%	100%	25%	35.02%	100–102, 104, 208, 211, 216–218, 222–224, 237, 239, 241, 243, 245, 247, 249, 251, 254, 256, 261–262, 270–291, 294–321, 324–435, 61–66, 97–99
wallet/src
amoeba.rs	0%	100%	0%	0%	100–106, 109–110, 112–118, 120–127, 19–48, 51–52, 54–99
cli.rs	0%	100%	0%	0%	103, 108, 119, 125, 14, 17, 19, 28, 33, 38, 45, 56, 68, 91
keystore.rs	0%	100%	0%	0%	31–33, 38–45, 47–48, 51, 53–59, 65–73, 76–78, 80–82, 85–91, 93–94
main.rs	0%	100%	0%	0%	101–102, 105–117, 120, 122–126, 129–133, 135–144, 146–147, 151–161, 164–165, 167, 170–171, 173, 175, 177–180, 182–184, 186, 190–197, 200–203, 205–207, 210–212, 214, 216, 219–225, 228–241, 244–247, 249–259, 26, 260, 262, 27–30, 33, 36–38, 40–41, 44, 46, 48–49, 53, 56–62, 65, 67–69, 73–76, 78, 80, 82–83, 86–87, 89, 91–93, 98–99
money.rs	0%	100%	0%	0%	100–101, 105, 109–112, 114, 119–125, 127–131, 134–135, 139–144, 146–147, 22–28, 31–49, 53–59, 65–72, 74, 78–83, 87, 90, 92, 95–98
output_filter.rs	100%	100%	100%	100%
rpc.rs	0%	100%	0%	0%	16–21, 24–26, 28–44, 47–53, 55–58, 60–61
sync.rs	0%	100%	0%	0%	103–106, 113–114, 116, 119–122, 127–129, 132–133, 136–141, 143–145, 148, 150–151, 156–159, 162–163, 170–174, 176–182, 185–187, 189–190, 193–194, 199–202, 205, 207–208, 213–216, 219, 221–222, 225–231, 233–234, 237–238, 241–242, 245–246, 250–256, 259–263, 266–268, 271–279, 281, 285, 287–288, 291–292, 295–302, 304–305, 308–309, 311, 313–314, 318–320, 322–323, 325–326, 328–329, 332–334, 336–337, 339–340, 342–343, 347, 349–350, 354, 356–361, 364–365, 368–370, 373, 376–379, 381, 384–387, 390, 393–394, 397–398, 403–408, 410, 412, 417–420, 423–424, 427–432, 434, 437–438, 442–443, 445, 447–449, 451–454, 457–458, 46–50, 54, 57–58, 61, 63–77, 82–86, 88–89, 94–99
wardrobe/amoeba/src
lib.rs	58.17%	100%	26.83%	69.64%	121, 139–140, 178–179, 81–82
tests.rs	100%	100%	100%	100%
wardrobe/kitties/src
lib.rs	54.40%	100%	33.05%	63.81%	100–101, 105–109, 115–117, 121–122, 125–127, 131–134, 138–140, 142–143, 147–151, 174–175, 178–185, 188, 191, 193, 195, 197, 199, 201, 203, 205, 207, 209, 211, 213, 215, 217, 219, 221, 223, 225, 354, 38, 386, 389, 39–40, 42–43, 449, 46–51, 54–56, 58–59, 64–68, 75–77, 79–80, 85–89, 96–98
tests.rs	99.61%	100%	98.25%	99.78%
wardrobe/money/src
lib.rs	42%	100%	18.75%	52.94%	100, 103, 105, 107, 111, 114, 117, 175, 21–23, 32–34, 36–37, 40–46, 50, 59–61, 63–65, 68–71, 75–77, 86–87, 90–97
tests.rs	100%	100%	100%	100%
wardrobe/poe/src
lib.rs	0%	100%	0%	0%	100, 108–117, 121–122, 128–129, 134–143, 147–151, 153–154, 167–168, 173–179, 39, 52, 55, 57, 59, 61, 65, 84–86, 91–99
wardrobe/runtime_upgrade/src
lib.rs	0%	100%	0%	0%	100–102,