Merged
Conversation
terencechain
previously approved these changes
Mar 17, 2023
| if !ok { | ||
| return nil | ||
| } | ||
| if err := s.streamPayloadAttributes(stream, emitSlot); err != nil { |
Collaborator
There was a problem hiding this comment.
Nice! another option is to do s.CurrentSlot() from one of the fetcher. This is fine too
terencechain
previously approved these changes
Mar 17, 2023
terencechain
previously approved these changes
Mar 17, 2023
terencechain
previously approved these changes
Mar 17, 2023
terencechain
approved these changes
Mar 17, 2023
avalonche
reviewed
Mar 17, 2023
|
|
||
| // streamPayloadAttributes on new head event. | ||
| // This event stream is intended to be used by builders and relays. | ||
| // parent_ fields are based on state at N_{current_slot}, while the rest of fields are based on state of N_{current_slot + 1} |
Contributor
There was a problem hiding this comment.
Suggested change
| // parent_ fields are based on state at N_{current_slot}, while the rest of fields are based on state of N_{current_slot + 1} | |
| // parent_ fields are based on state at N_{current_slot}, while the rest of the fields are based on state at N_{current_slot + 1} |
Contributor
Author
There was a problem hiding this comment.
Will make note and hopefully fix in another PR don't want to block this one and retrigger CI/CD for comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
fixes the missed json type casing on
datawill also send the head information on missed slots
Which issues(s) does this PR fix?
Fixes #12153
related to #12102