Fix issues on win32, regex escapes, and over-matching#3
Merged
OlehDutchenko merged 1 commit intoOlehDutchenko:masterfrom Aug 27, 2019
Merged
Conversation
2680be2 to
68fd811
Compare
Owner
|
@AprilArcus - I'am just already updated new version at npm - 1.0.3, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes three issues:
reactbut notreact-dom:1.0.1(wrong)This PR(correct)We were previously not accommodating win32-style path separators inside module names, e.g. the forward slash inside
@types/reactorlodash/isequalwould break when running webpack on Windows. This patch assumes POSIX-style input and reformats scoped node modules as appropriate.We were previously not performing regex escapes on the exception list, which could conceivably lead to problems. This patch adds
sindresorhus/escape-string-regexpas a dependency and uses it to sanitize user input.