bug: catch exception if opening a notification fails#2508
Merged
abdulraqeeb33 merged 1 commit intomainfrom Dec 28, 2025
Merged
Conversation
18 tasks
Contributor
📊 Diff Coverage ReportDiff Coverage ReportThreshold: 80% Changed Files Coverage
Overall Coverage0/137 lines covered (0.0%) ❌ Coverage Check FailedFiles below 80% threshold:
|
nan-li
approved these changes
Dec 26, 2025
Contributor
Author
yeah i was assuming this is our code, atleast we should catch and print the exception |
This was referenced Jan 5, 2026
jinliu9508
pushed a commit
that referenced
this pull request
Jan 6, 2026
Co-authored-by: AR Abdul Azeez <abdul@onesignal.com>
This was referenced Jan 8, 2026
This was referenced Jan 26, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Catch and Log an exception when opening a destination activity fails thru Notification
Details
Motivation
Provide better user experience by catching and logging errors when it fails to open a destination activity.
This is in response to the PR https://github.com/OneSignal/OneSignal-Android-SDK/pull/1954/changes
Scope
Better logging.
Testing
Unit testing
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is