fix: end initialization early if device storage is locked#2520
Merged
jinliu9508 merged 1 commit intomainfrom Jan 27, 2026
Merged
fix: end initialization early if device storage is locked#2520jinliu9508 merged 1 commit intomainfrom
jinliu9508 merged 1 commit intomainfrom
Conversation
Contributor
📊 Diff Coverage ReportDiff Coverage ReportThreshold: 80% Changed Files Coverage
Overall Coverage66/379 lines covered (17.4%) ❌ Coverage Check FailedFiles below 80% threshold:
|
0c270f6 to
7ec8687
Compare
jinliu9508
commented
Jan 26, 2026
| initState = InitState.FAILED | ||
| notifyInitComplete() | ||
| return false | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This part can be in a separate function
abdulraqeeb33
approved these changes
Jan 26, 2026
Contributor
abdulraqeeb33
left a comment
There was a problem hiding this comment.
we discussed on the call and this seems to be a good solution.
Only the diff coverage has failed. but the tests have passed
jinliu9508
added a commit
that referenced
this pull request
Jan 27, 2026
jinliu9508
added a commit
that referenced
this pull request
Jan 27, 2026
jinliu9508
added a commit
that referenced
this pull request
Jan 27, 2026
nan-li
pushed a commit
that referenced
this pull request
Jan 27, 2026
nan-li
added a commit
that referenced
this pull request
Jan 27, 2026
jinliu9508
added a commit
that referenced
this pull request
Jan 27, 2026
jinliu9508
added a commit
that referenced
this pull request
Jan 27, 2026
This was referenced Jan 28, 2026
This was referenced Jan 30, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add isDeviceStorageUnlocked check to avoid accessing user data before the device is unlocked on Android 7.0+, and end initialization early if device storage is locked.
Details
Motivation
This allows the SDK to avoid reading/writing user data too early (e.g., in boot receivers or early background services), and to avoid crashes with the inconsistent state.
Scope
Terminate the initialization early depends on user storage availability.
Testing
Unit testing
Two test cases are added.
Manual testing
Tested on Emulator Pixel 9 API 35
Step to reproduce:
<receiver android:name="com.onesignal.notifications.receivers.BootUpReceiver" android:exported="true" android:directBootAware="true"> <intent-filter> <action android:name="android.intent.action.BOOT_COMPLETED" /> <action android:name="android.intent.action.QUICKBOOT_POWERON" /> <action android:name="android.intent.action.LOCKED_BOOT_COMPLETED"/> </intent-filter> </receiver>adb logcat | grep -E "(SharedPreferences|BootUpReceiver)"
After fix:
The exception is no longer thrown in the background. After the user has unlocked the device, notifications can be received and interacted as normal even the app is not opened.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is