Merged
Conversation
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
8c86ece to
4a89b3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Cordova ios custom events
Cordova android custom events
Example app:
Details
OneSignalController.java&OneSignalPush.javato expose new android sdk trackEvent method. Adds Map helper functions to deal with complex object propertiesOneSignalPush.m(& header) to expose new track ios sdk trackEvent methodUserNamespace.tsfile to have new trackEvent method to call respective platform's trackEvent functionMotivation
Want to allow usage for custom events method to more sdks / developers.
Testing
ionic capacitor run androidionic capacitor run iosAffected code checklist
Checklist
Overview
Testing
Final pass
This change is