Skip to content

chore: update dotnet example to match other sdks#157

Merged
fadi-george merged 23 commits into
mainfrom
fg/update-demo
Feb 24, 2026
Merged

chore: update dotnet example to match other sdks#157
fadi-george merged 23 commits into
mainfrom
fg/update-demo

Conversation

@fadi-george
Copy link
Copy Markdown
Contributor

@fadi-george fadi-george commented Feb 21, 2026

Description

One Line Summary

  • update the dotnet example to match other sdks features and look
Screenshot 2026-02-20 at 4 54 41 PM Screenshot 2026-02-20 at 4 54 52 PM Screenshot 2026-02-20 at 4 54 57 PM

Details

  • has android push capability
  • has ios push capability and supports displaying image via NSE
  • has ios + android location sharing
  • has app icons like other new sdk demos
  • has new build + build_ios prompts
  • adds run_ios and run_android script helpers to help choose from simulator options

Motivation

Want consistent demos between the sdks

Testing

Unit testing

Tested against both android and ios emulators/simulators

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

Copy link
Copy Markdown
Contributor

@sherwinski sherwinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very nit but the input text fields auto-capitalize the first letter. I only noticed because I wanted to test logging in with an external ID like user but it capitalized it to User instead. Although, I think it's something that can be configured:

-    public Keyboard Keyboard { get; init; } = Keyboard.Default;
+    public Keyboard Keyboard { get; init; } = Keyboard.Plain;
Image

@fadi-george fadi-george force-pushed the fg/update-demo branch 5 times, most recently from 08658d1 to 89448f5 Compare February 24, 2026 07:54
@fadi-george fadi-george force-pushed the fg/update-demo branch 5 times, most recently from 8845f6b to 4bfe70e Compare February 24, 2026 09:30
@fadi-george fadi-george merged commit a60fb7d into main Feb 24, 2026
5 checks passed
@fadi-george fadi-george deleted the fg/update-demo branch February 24, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants