feat: add ClearAllNotifications and simplify demo build guide#162
Merged
fadi-george merged 9 commits intomainfrom Mar 10, 2026
Merged
feat: add ClearAllNotifications and simplify demo build guide#162fadi-george merged 9 commits intomainfrom
fadi-george merged 9 commits intomainfrom
Conversation
Replaces comprehensive build instructions with a concise guide that extends the shared build documentation from sdk-shared repo, reducing duplication and maintenance overhead.
nan-li
requested changes
Mar 10, 2026
nan-li
left a comment
There was a problem hiding this comment.
Public API should be OneSignal.Notifications.clearAll() to match API on all other platforms
Contributor
Author
Done, for C# were using pascal case |
11ca5aa to
14258c8
Compare
14258c8 to
9982556
Compare
abdulraqeeb33
approved these changes
Mar 10, 2026
nan-li
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Addresses: #133
Add
ClearAllNotificationsto the SDK interface and wire it up in the demo app, plus simplify the demo build guide to reference the shared sdk-shared docs.Details
Motivation
The demo app was missing a way to clear all delivered notifications. Other wrapper SDKs already expose this. The build guide was also duplicating content that now lives in the shared
sdk-shared/demo/build.md, so it was trimmed to only contain .NET MAUI-specific details.Scope
SDK interface gains
ClearAllNotifications()onINotificationsManager, implemented on both Android and iOS. The demo app gets a new "CLEAR ALL" button in the Send Push Notification section. The build guide is restructured to reference the shared guide and only list DotNet-specific overrides.Changes
SDK (public API)
INotificationsManagergainsvoid ClearAllNotifications()OneSignalNative.Notifications.ClearAllNotifications()OneSignalNative.Notifications.ClearAll()Demo app
OneSignalRepository.ClearAllNotifications()wraps the SDK callAppViewModel.ClearAllNotifications()command with log messageSendPushSection.xamladds a CLEAR ALL button (AutomationId="clear_all_notifications_button")SendPushSection.xaml.cswires the click handlerBuild guide
examples/build.mdnow references the sharedsdk-shared/demo/build.mdand only contains .NET MAUI-specific overrides (reduced from ~1095 to ~339 lines)Testing
Manual testing
Built and ran the demo app on Android emulator. Verified the CLEAR ALL button calls through to the SDK and clears delivered notifications from the tray.
Android
iOS
Affected code checklist
Checklist
Overview
Testing
Final pass