Conversation
remove test calls to User.OneSignalId and User.ExternalId
shepherd-l
approved these changes
Mar 29, 2024
Contributor
There was a problem hiding this comment.
Lgtm!
Tested the following on the example app on an emulated Pixel 4 with Android 12 and emulated iPhone 15 with iOS 17.0
- OneSignalId and ExternalId getters
- Return null. Tested on a new app install with Wifi off (tested on Android but not iOS)
- Return values on login and logout
- User changed handler
- Fired on login and logout
- Fired on fresh install when a new user is created
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add OneSignalId and ExternalId getters as well as a user changed observer.
Details
Add User.onesignalId and User.externalId
Also adds User.changed observer to handle changes to either id.
Motivation
Allow apps to get the current OneSignalIdd and external id. Since they can be null we also are adding the ability to observe when the OneSignalId and external id change (including null to non-null).
Scope
New methods on the user namespace
Testing
Manual testing
Tested login/logout on both iOS and Android emulators
Affected code checklist
Checklist
Overview
Testing
Final pass