Unable to upload to App Store Connect

[loganblevins]

Error with Xcode Version 12.4 (12D4e):

The bundle Payload/Covenant Eyes.app/PlugIns/OneSignal.framework is not contained in a correctly named directory. It should be under "Frameworks".".

Issue is resolved by hand, deleting framework from PlugIns.

https://forums.swift.org/t/swift-package-binary-framework-issue/41922

However, OneSignal is the only troublesome SPM package I've encountered - and we use multiple SPM packages.

Is there anything OneSignal can do to resolve this?

[loganblevins]

We have had to revert back to the standard framework package to avoid this bug.

This XCFramework is quite literally unusable as-is. Our automated builders are failing to upload to App Store Connect and we cannot rely on developers deleting a duplicate framework within an archive to make the upload succeed.

[blorsch]

We are also experiencing this issue. After adding via SPM OneSignal works perfectly and can be archived, but when we go to upload to App Store Connect we receive a whole slew of errors:

If I inspect the .app file, it looks like OneSignal.framework and the notification app extension are being placed within the "PlugIns" folder, erroneously according to Xcode. We have other SPM packages and we’ve been able to successfully upload builds for months with them. We are planning to use OneSignal in production, but we can’t until we can upload builds.

Any help would be much appreciated. This is with OneSignal-XCFramework v3.3.0 and Xcode 12.4.

[josala]

I had the same issue and I had to remove the OneSignal Swift package and install it via pod. Make sure to specify the latest version (currently pod 'OneSignal', '3.4.0') because otherwise installs 2.x and has some incompatibilities with the current SDK setup guide.

[zoejessica]

We are running into exactly the same issue - we were able to resolve (on CI too) by adding a final build phase script that removes the OneSignal framework from the Plugins folder, as per this technique by Kevin Bui. $(BUILT_PRODUCTS_DIR)/$(PLUGINS_FOLDER_PATH)/OneSignal.framework needs to be added as an Input File for the script.

Update: turned out to not be reliable - also reverting back to OneSignal-iOS-SDK for now.

[salami]

Same problem here. Using OneSignal-XCFramework SPM on an M1 Apple Silicon Mac. Xcode 12.5

I just switched over to OneSignal-iOS-SDK for now, still using SPM. Please address this, thank you.

[acoomans]

+1 same issue here. Would like to see this solved.

[emawby]

Thank you for reporting I am looking into this. It seems like other Binary Swift Packages are having similar issues . I was hopeful that Xcode 12.5 would solve the issue, but it seems it hasn't.

To be clear are folks having issues archiving their apps or is there only an issue occurring once the archive has been uploaded to App Store connect? In my testing I am able to successfully archive, but if I have an app extension or app clip that also uses the OneSignal library from the XCFramework Swift Package then validation fails when uploading to app store connect.

[salami]

The archive is successful. The error occurs at the end of the upload process and it does not get sent to App Store Connect.

[emawby]

I am able to reproduce this. I get the same errors as when I include the XCFramework directly and embed it both the App and Extension targets. I am not sure why SwiftPM is trying to embed the framework when it doesn't need to. I will look into ways to modify the Package itself to make it not do that, but otherwise we will need a build script or manual deletion of the framework from the plugin to resolve the issue until Apple addresses it. I apologize for the inconvenience.

The manual workaround that works for me is to modify the archive before validating/distributing it.

1. Right click the Archive
2. Show in finder
3. Right click > Show package contents of the .xcarchive
4. Products > Applications > xx.app > Right click Show package contents
5. Plugins > OneSignalNotificationServiceExtension.appex > Right click Show package contents
6. Delete the Frameworks folder.

If you have an app clip or other app extensions that depend on the XCFramework you will need to delete the Frameworks folder from them as well.

[imrealashu]

@emawby I've been facing the same issue and ended up here and did the steps you've mentioned. It solved two of the errors, thanks for that but, this still has 2 issues. Could you help me point out what are those?
I'm using React Native (>0.60) with OneSignal.

Thanks in advance!

[emawby]

@imrealashu What version of React-Native-OneSignal are you using?

[emawby]

Updating with another workaround. Instead of directly including the OneSignal library in the NotificationServiceExtension target you can update the NSE's Runpath search paths build setting to include the path @executable_path/../../Frameworks. This will make it so that the NSE will look for Frameworks in the main app targets Frameworks directory.