Update IAM view controller to hide status bar on full-bleed In-App Messages#1390
Merged
Update IAM view controller to hide status bar on full-bleed In-App Messages#1390
Conversation
2140c45 to
360ad31
Compare
Contributor
Author
|
PR has been updated to only remove status bar on full screen IAM. |
Contributor
5f56349 to
55eed10
Compare
Contributor
Author
|
Updated to only hide status bar for full-bleed IAMs. |
nan-li
approved these changes
Apr 12, 2024
This was referenced Apr 15, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Update
OSInAppMessageViewControllerto hide status bar on full screen, no margin (AKA full-bleed) In-App Messages.Details
Motivation
When an In-App Message displays, the iOS Status Bar appears even if hidden in the app. This fix assess whether the In-App Message is full screen without margins and if so, sets the property
prefersStatusBarHiddento true so that the status bar will not display. Note that for banner, center modal, and full screen with margin In-App Messages, the status bar will remain visible.Scope
This change affects only the
OSInAppMessageViewController.Testing
Manual testing
Tested a series on In-App Messages where the status bar appears on a center modal IAM, full screen IAM, and banner IAM, then is removed for a full-bleed IAM:
Testing was done on an iPhone 15 Emulator running iOS 17.2.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is