Cleanup IAM window on the main thread when failing to load#1447
Merged
Conversation
…sage content All other cleanups are coming from the UI thread, but this one is not. This fixes a crash that happens if multiple IAMs have the same trigger and one of the IAMs after the first fails to load
jennantilla
approved these changes
May 31, 2024
This was referenced Jun 12, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix crash that can occur in some cases when we fail to load an IAM
Details
If multiple IAMs have the same trigger then we will have an IAM window that needs to be cleaned up when one of them fails to load. This fix was introduced in this pr, but the failure is not guaranteed to return on the UI thread so it would crash in some cases.
Motivation
Fix crash
Scope
IAM
Testing
Unit testing
none
Manual testing
Manually reproduced with break points and pausing active IAMs as they were about to load
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is