Stop deleting PTU tokens when a Live Activity enters a dismissed state#1556
Closed
Stop deleting PTU tokens when a Live Activity enters a dismissed state#1556
Conversation
This is contributing to a race condition where if a PTS notification is sent twice we can sometimes never send an upsert PTU token request because the delete request will replace it client side.
cstyles
reviewed
Apr 30, 2025
| @@ -217,7 +217,6 @@ public class OneSignalLiveActivitiesManagerImpl: NSObject, OSLiveActivities { | |||
| for await activityState in activity.activityStateUpdates { | |||
| switch activityState { | |||
| case .dismissed: | |||
There was a problem hiding this comment.
Do we want a break here?
Suggested change
| case .dismissed: | |
| case .dismissed: break |
Contributor
Author
|
handing this off to SDK team instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is contributing to a race condition where if a PTS notification is sent twice we can sometimes never send an upsert PTU token request because the delete request will replace it client side.
suspects:
READ AND DELETE THIS SECTION BEFORE SUBMITTING PR
Description
One Line Summary
REQUIRED - Very short description that summaries the changes in this PR.
Details
Motivation
REQUIRED - Why is this code change being made? Or what is the goal of this PR? Examples: Fixes a specific bug, provides additional logging to debug future issues, feature to allow X.
Scope
RECOMMEND - OPTIONAL - What is intended to be effected. What is known not to change. Example: Notifications are grouped when parameter X is set, not enabled by default.
OPTIONAL - Other
OPTIONAL - Feel free to add any other sections or sub-sections that can explain your PR better.
Testing
Unit testing
OPTIONAL - Explain unit tests added, if not clear in the code.
Manual testing
RECOMMEND - OPTIONAL - Explain what scenarios were tested and the environment.
Example: Tested opening a notification while the app was foregrounded, app build with Android Studio 2020.3 with a fresh install of the OneSignal example app on a Pixel 6 with Android 12.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is