Conversation
• Adds the capability to require user privacy consent before the SDK can be initialized
• Made it so that when the user revokes consent after granting it, the SDK will immediately stop sending any information to the server • Added checks in some internal methods to make sure personal data is never sent when consent is revoked or not provided
• Adds consent checks to location data so that the SDK will not send location data if consent is revoked • Adds nullability specifiers to the new DelayedInitializationParameters class
• Adds a method to override the plist consent setting, intended for wrapper SDK's that cannot use a plist setting
|
Review status: 0 of 14 files reviewed at latest revision, all discussions resolved, some commit checks failed. iOS_SDK/OneSignalSDK/UnitTests/UnitTests.m, line 1865 at r1 (raw file):
Can you try calling a few other OneSignal methods here like sendTags in the test? iOS_SDK/OneSignalSDK/UnitTests/UnitTests.m, line 1876 at r1 (raw file):
Can we add a 2nd test for Comments from Reviewable |
• Changes the SDK so that iOS params are still downloaded even if the user has not provided consent yet (to make things faster if they do eventually provide consent) • Added additional checks to ensure that the SDK will _never_ initiate an HTTP request (asides from GET requests) if the user has not provided consent • Adds test to make sure that swizzled methods (ie. didRegisterForRemoteNotifications) do not initiate HTTP requests or change state (ie. push token) if consent has not been granted • Adds a test to make sure the OneSignal setRequiresUserPrivacyConsent: override method works correctly • Adds a check to make sure handleNotificationOpened: does not execute if the user has not provided consent
|
Reviewed 10 of 14 files at r1, 4 of 4 files at r2. iOS_SDK/OneSignalDevApp/OneSignalDevApp/Info.plist, line 5 at r2 (raw file):
This should be Comments from Reviewable |
• Changes the privacy consent parameter name capitalization from Onesignal_require_privacy_consent to OneSignal_require_privacy_consent to be more consistent
|
Reviewed 2 of 2 files at r3. Comments from Reviewable |
• Adds ability to require privacy consent and lets developers add privacy consent/revoke to their apps
• Uses
Onesignal_require_privacy_consentinfo.plist key to let developers require consent• Adds
consentGranted(boolean)to indicate if the user gives their consent. Can also be used to revoke previously granted consentThis change is