Skip to content

Conversation

@bgn42
Copy link
Collaborator

@bgn42 bgn42 commented Feb 19, 2025

Fixes

#385

Changes

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@bgn42 bgn42 requested a review from jkrech February 19, 2025 16:59
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to identify the +meta part of the version and print it as part of the message.

Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 7c7facf and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 71.4% (50% is the threshold).

This pull request will bring the total coverage in the repository to 58.8% (0.0% change).

View more on Code Climate.

@bgn42 bgn42 merged commit cbb4419 into main Feb 21, 2025
19 of 20 checks passed
@bgn42 bgn42 deleted the issue385 branch February 21, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants