fix: boxing in singlescreen mode#1014
Merged
kaamui merged 1 commit intoOpenBoard-org:devfrom Aug 13, 2024
Merged
Conversation
- return false for hasDisplay and hasPrevious in single monitor mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
then the control display was still boxed as if the display screen (projector) was used.
This PR fixes the values returned by
hasDisplay()andhasPrevious()in theUBDisplayManagerto include the value of the multi-monitor flag.Related issues:
Note: This is not the same problem as addressed by #901. In that PR it is about scaling of control and display view in multi-monitor mode. This PR fixes a problem in single-monitor mode.