Support FFmpeg 7.0#1017
Merged
Merged
Conversation
The `channels` attribute was deprecated for a long time and has finally been removed with 7.0. Use `ch_layout.nb_channels` which is the recommended alternative.
`avcodec_close` has been discouraged from use since 2.3 and is formally deprecated with 7.0. Use `avcodec_free_context` instead. `avcodec_free_context` takes a double pointer as argument.
letsfindaway
approved these changes
Jun 18, 2024
Contributor
Author
|
FFmpeg 7 has been released on Arch. Deviating from usual practice, I've updated the AUR package with this patch to keep it building and allow OpenBoard to continue running. I don't expect any issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With FFmpeg 7.0 entering Arch Linux extra-testing, it's a good time to get support for it in OpenBoard.
This PR fixes the compilation errors and resolves related warnings.
The proposed alternatives are available since 5.1 at least, so the pragmas could be lowered to get rid of warnings in previous versions - I've elected to keep the change as small as possible, so the fix only applies to version 7.0.
I'd like to have this commit merged before Arch upgrades FFmpeg to general availability, though I don't have a timeline for when that will happen. A new release of OpenBoard is not necessary.
Fixes #1002