fix: apply scene keyboard shortcuts w/o modifier only#1018
Merged
kaamui merged 1 commit intoOpenBoard-org:devfrom Aug 13, 2024
Merged
fix: apply scene keyboard shortcuts w/o modifier only#1018kaamui merged 1 commit intoOpenBoard-org:devfrom
kaamui merged 1 commit intoOpenBoard-org:devfrom
Conversation
- the keyboard shortcuts for scene commands prev/next/first/last/add should only be active when no modifier key is pressed - this resolves conflicts with the same keys used together with Ctrl modifier used for panning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a long-standing bug for keyboard shortcuts:
Ctrlmodifier used for panning.This bug was reported three years ago (#494) and is still not fixed.