Fix Dice widget and add automatic update#1022
Merged
kaamui merged 2 commits intoOpenBoard-org:devfrom Aug 13, 2024
Merged
Conversation
- when a newer version of a widget is available in the library then update a widget in a document to that version - only update if major version number does not change, as this might indicate an incompatible change
- Dice widget was missed when updating uwb-main based widgets - apply the changes also used for other similar widgets - update version number to 2.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When updating the interactivity widgets to the new OpenBoard API, the
Dicewidget was forgotten. This PR fixes this in two commits:UBWidgetUpgradeAdaptor. It was initially written to upgrade widgets which have been using the old API to updated versions using the new API. The extension added now can also update a widget already using the new API to a new version.uwb-mainbased widgets.The automatic version update makes sure that widgets on already existing documents get automatically updated. The update is performed if
This PR fixes #1020.