Fix delegate handle recognition#1106
Merged
kaamui merged 1 commit intoOpenBoard-org:devfrom Feb 11, 2025
Merged
Conversation
letsfindaway
force-pushed
the
fix-delegate-handle-recognition
branch
from
018dd17 to
aaccb7b
Compare
- the handles on a delegate frame may be stacked on each other if the delegate frame is small in one or the other direction - determine tool from mouse position by asking the topmost handle first - use isUnderCursor() to be sure that the tool matches the currently shown cursor - remove unreachable "return"
letsfindaway
force-pushed
the
fix-delegate-handle-recognition
branch
from
aaccb7b to
ba0eedd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1105:
if the delegate frame is small in one or the other direction
handle first
isUnderCursor()to be sure that the tool matches thecurrently shown cursor
return