Merged
Conversation
letsfindaway
force-pushed
the
feat-snap-action
branch
from
5b6612d to
71ee10b
Compare
- switch snap-to-grid using action - add action button to stylus palette - switch action state with Shift key to keep previous behavior
- resource file keyboardOn.png referenced in actionVirtualKeyboard but not included in resource file OpenBoard.qrc
- add snap.svg and snapOn.svg - add icons to resource file - add icon resources to action
letsfindaway
force-pushed
the
feat-snap-action
branch
from
71ee10b to
78906de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the snap action as described in discussion #1100. Icons courtesy of @fadikdawoud.
Shiftkey to keep previous behaviorsnap.svgandsnapOn.svgprovided by @fadikdawoud.Additionally it fixes a missing resource for the onscreen keyboard action button.
keyboardOn.pngreferenced inactionVirtualKeyboardbut not included in resource fileOpenBoard.qrc