fix: dropping pdf url to board#1157
Merged
kaamui merged 1 commit intoOpenBoard-org:devfrom Feb 11, 2025
Merged
Conversation
- when dropping a url to the board, the data is downloaded and then processed in UBBoardController::downloadFinished - for a pdf, the data is written to a temp file and then imported - before importing, the file must be closed to write pending data from buffers to disk
Collaborator
Author
|
See also #1209 reporting another way to provoke this bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves a problem when dropping a PDF url to the board. Expected behavior is that the same functions are executed as when dropping a PDF document to the board. Instead in most cases just nothing happens.
UBBoardController::downloadFinished