Performance: background loader#1227
Merged
kaamui merged 2 commits intoOpenBoard-org:devfrom Feb 14, 2025
Merged
Conversation
- load a list of files on a separate thread - provide files contents as QByteArray - guarantee sequence of files
- provide a list of thumbnail file names - use UBBackgroundLoader to load them on a separate thread - create thumbnails from results on the main thread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a background loader to read thumbnail files in another thread so that disk I/O, especially with a slow network drive, does not interfere with user actions.
The new class
UBBackgroundLoadertakes a list of file names and produces a list of results containing the data in these files in the same sequence. The I/O operations are performed on another thread.The
UBThumbnailSceneis adapted to use the background loader for reading thumbnail file data. This avoids blocking operations on the main thread and improves user experiences during thumbnail loading.