Merged
Conversation
- emit signals when a scene was duplicated, deleted or moved - handle signals in UBBoardController to update selected scene - update metadata in UBDocument when it was changed - avoid forwarding of mouse event after a UI button was pressed
- use QVector instead of QList - provides constructor with size argument Fixes OpenBoard-org#1235, thanks @sebojolais
- selection in board mode after using UI button - don't change selection in document mode after using UI button - don't force loading all thumbnails when selecting range
- separate selection in Board mode from Document mode - sync selection in Board mode with Document mode manipulations - save scene before moving - display dialog before deleting page(s) - inhibit de-selection of page in Board mode
- adapt board selection when scenes are inserted/moved/deleted - remove duplicate event forwarding in UBDocumentThumbnailsView
- use UBDocument when deleting pages in Document mode with the action button - don't duplicate confirmation dialog moved to UBDocument
letsfindaway
force-pushed
the
fix-incomplete-ubdocument
branch
from
33fb87d to
7d5feb7
Compare
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes the work on
UBDocumentas far as it addresses the issues described in letsfindaway#208.Fixing issues with scene duplication
Fixing issues when selecting pages
Fixing issues in document handling
Refactor confirmation dialog
There is also a list of tests passed with this PR.