fix: detect delegate handle with tablet pen#1288
Merged
kaamui merged 1 commit intoOpenBoard-org:devfrom Jun 24, 2025
Merged
Conversation
- do not use isUnderMouse as this does not work with tablet pen - instead determine delegate handle from position using contains() Signed-off-by: letsfindaway <me@letsfindaway.de>
|
Hey @letsfindaway I having been trying it out for a couple of days now to make sure everything is working fine and It's safe to say that it works wonderfully fine, thank you so much I really am thankful for the work you do and the effort you put in, you're a true inspiration!!!! |
Collaborator
Author
Thanks for testing! Then I take this as confirmation of this PR and think it should be part of 1.7.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to fix letsfindaway#221 as reported here #1270 (comment).
isUnderMouse()as this does not work with tablet pen (in some cases)contains()We still do not use the function calls like
rotateButtonBounds().contains(pos), as these do not guarantee a complete alignment between the cursor shape and the actual action performed when the mouse button is pressed.This PR is tested with a Wacom One pen display. However I do not have and cannot reproduce the problem described by @fadikdawoud with this device even with the current
devbranch. So I would like to ask @fadikdawoud whether my PR works for you.