Merged
Conversation
- do not register axes as a tool when creating - do not register axes as a tool when loading a page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When exporting a document containing axes to PDF, the axes are not exported. They are currently treated as a tool like the ruler or compass, which do not belong to the page content. However he axes are different. They are an integral part of the page content and should be exported.
This PR avoids registering axes as a tool when creating them and when loading a document page containing axes.
This PR is related to #924. It only addresses the axes tool, where it is evident that it is part of the page content. For other tools like ruler, protractor or triangle it can still be discussed whether they should be part of the PDF export.