Skip to content

Add selectable controller background styles#368

Merged
Jayian1890 merged 1 commit intodevfrom
release/20260427-0414
Apr 27, 2026
Merged

Add selectable controller background styles#368
Jayian1890 merged 1 commit intodevfrom
release/20260427-0414

Conversation

@Jayian1890
Copy link
Copy Markdown
Collaborator

Summary

  • add a dedicated controller background style setting (ribbon, mesh, grid) separate from existing color themes
  • apply style + theme consistently across controller library and controller loading overlays
  • add new settings controls and style-specific CSS treatments while preserving existing animation toggle behavior

Test plan

  • npm run typecheck --prefix opennow-stable
  • verify edited files have no lints
  • in app settings, switch style/theme combinations and confirm controller library visuals update
  • launch/switch in controller mode and confirm loading overlay matches selected style/theme

Made with Cursor

This introduces distinct visual style options (ribbon, mesh, grid) while keeping existing theme palettes, so users can personalize controller UI visuals and get consistent style/theme behavior on loading overlays.

Made-with: Cursor
@Jayian1890 Jayian1890 merged commit f398c0b into dev Apr 27, 2026
8 checks passed
@Jayian1890 Jayian1890 deleted the release/20260427-0414 branch April 27, 2026 09:15
Copy link
Copy Markdown
Contributor

@capy-ai capy-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added 1 comment

Comment on lines +6870 to +6872
.xmb-wrapper.xmb-bg-style-grid.xmb-animate .xmb-bg-gradient::before {
animation: xmb-grid-pulse 10s ease-in-out infinite;
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[🟡 Medium] [🔵 Bug]

The grid background style defines animation overrides for .xmb-bg-gradient (xmb-grid-pan) and .xmb-bg-gradient::before (xmb-grid-pulse), but there is no .xmb-wrapper.xmb-bg-style-grid.xmb-animate .xmb-bg-gradient::after rule. The pre-existing ribbon animation rule:

/* line 6643 */
.xmb-wrapper.xmb-animate .xmb-bg-gradient::after {
  animation: xmb-ribbon-swell 22s ease-in-out infinite;
}

matches when grid + xmb-animate is active because the selector still applies (the element has both xmb-wrapper and xmb-animate classes). The animation property isn't overridden by any grid-specific rule for ::after, so xmb-ribbon-swell runs on the grid's noise-dot pseudo-element. That keyframe animates opacity between 0.74–0.9 and applies transform scaling/rotation — completely overriding the grid's intended static opacity: 0.24 and producing visible visual artifacts (swelling/rotating noise dots). Add animation: none for the grid ::after to cancel the inherited ribbon animation.

Suggested change
.xmb-wrapper.xmb-bg-style-grid.xmb-animate .xmb-bg-gradient::before {
animation: xmb-grid-pulse 10s ease-in-out infinite;
}
.xmb-wrapper.xmb-bg-style-grid.xmb-animate .xmb-bg-gradient::before {
animation: xmb-grid-pulse 10s ease-in-out infinite;
}
.xmb-wrapper.xmb-bg-style-grid.xmb-animate .xmb-bg-gradient::after {
animation: none;
}

Jayian1890 added a commit that referenced this pull request Apr 27, 2026
This introduces distinct visual style options (ribbon, mesh, grid) while keeping existing theme palettes, so users can personalize controller UI visuals and get consistent style/theme behavior on loading overlays.

Made-with: Cursor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant