Draft
Conversation
Contributor
|
I don't think that rewriting the encode/decode for the dcc and dc6 format should be part of this PR. those are two very large changes, each deserving their own PR. |
Author
|
Sure then, I'll revert those changes |
Contributor
|
What's the status on this? |
Author
|
I'm doing great, I'm working with a single property in an embedded structure that the linter detected as not used even if it was, so I'm finding a new way to re-write the structure. |
Contributor
btw, it is a known bug with unexported struct fields. you can just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Created
This PR is a work in progress, its creation is to show the current development of the issue. I'll make changes.
Things to be done