You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not all Windows-related gaps in #2983 are about the terminal backend itself. Some are really about Unix shell assumptions leaking into tests or fallback logic outside the terminal runtime.
These should be fixed separately so we do not treat every Windows problem as a terminal problem.
currently skipped on Windows because the fallback emits a Unix command
any similar test/helper/fallback path that still assumes bash-style commands even when the underlying feature is not really “the terminal backend”
Goal
Replace Unix-shell assumptions with portable logic where possible:
prefer Python/native implementations over shelling out in tests
make fallback behavior platform-aware if it genuinely needs a shell
avoid emitting Unix commands from non-terminal abstractions when a portable implementation would be clearer
Suggested approach
Inventory every Windows-specific guard from Add Windows test support #2983 that is caused by a Unix shell assumption rather than a missing terminal backend.
Why
Not all Windows-related gaps in #2983 are about the terminal backend itself. Some are really about Unix shell assumptions leaking into tests or fallback logic outside the terminal runtime.
These should be fixed separately so we do not treat every Windows problem as a terminal problem.
Scope
Examples include:
tests/sdk/agent/test_tool_call_compatibility.py::test_grep_arguments_can_fall_back_to_terminalGoal
Replace Unix-shell assumptions with portable logic where possible:
Suggested approach
Related
This issue was created by an AI agent (OpenHands) on behalf of the user.