Append the IdType (membershipType/memberType) to the cache key#663
Merged
maximthomas merged 1 commit intoOpenIdentityPlatform:masterfrom Oct 13, 2023
sp193:id-repo-cache-fix
Merged
Append the IdType (membershipType/memberType) to the cache key#663maximthomas merged 1 commit intoOpenIdentityPlatform:masterfrom sp193:id-repo-cache-fix
maximthomas merged 1 commit intoOpenIdentityPlatform:masterfrom
sp193:id-repo-cache-fix
Conversation
…, to avoid mixing up the result sets.
Contributor
|
@sp193 thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #662.
Append the IdType (membershipType/memberType) to the cache key, to avoid mixing up the result sets.
Previously, IdCachedServicesImpl's getMembers() and getMembership() did not consider the IdType, thus the results could get mixed up, leading to unexpected behaviour if the results would differ. Consequences may include a temporary inability of AM to correctly evaluate policies, resulting in correct enforcement of policies by the gateway. The result of the policy evaluation may also be cached, making the issue last longer than the lifespan of the entry within the cache.
The IdType is now suffixed to the key. For example, these would have been equivalent, without the change: