Automatic Typing for Default Message Detailer

[iamtrask]

Is your feature request related to a problem? Please describe.
At present, the default detailer for Message (an abstract type) returns an object of type Message instead of returning an object of the correct type.

Describe the solution you'd like
Use the msg_tuple[0] to look up the correct type.

Describe alternatives you've considered
Return NotImplementedException instead and require all Message types to have their own detailers.

[PlamenHristov]

I think this issue requires some clarification. From what I understand Message.simplify() and Message.detail() should be inverses of each other. However, I don' think that's exactly what's happening. If we consider the test below:

def test_message_detail_returns_specific_type():
    tensor = th.tensor([1, 2, 3, 4])
    operation = message.Operation(
        cmd_name="_add__",
        cmd_owner=tensor,
        cmd_args=(tensor,),
        cmd_kwargs={},
        return_ids=96100376575,
    )

    wrapped = message.SearchMessage(operation)
    simplified_operation = message.Message.simplify(sy.local_worker, wrapped)
    detailer = detailers[simplified_operation[0][0]]
    detailed_operation = message.Message.detail(sy.local_worker, simplified_operation)

    assert isinstance(detailed_operation, message.Operation)

when Message.simplify() takes the contents of wrapped, because it reads the wrapped.contents, it effectively removes the knowledge of the SearchMessage object and returns directly the Operations object.

Next when the simplified object gets passed to Message.detail() it only has info for the Operations object thus the only thing it can do is wrap it in a Message object.

There are two ways to approach this and have a "fix" for the issue. Either:

• Don't take the contents of the message on Message.simplify(), but the whole ptr, then Message.detail() can do return sy.serde.msgpack.serde._detail(worker, msg_tuple[0])

OR

• Keep Message.simplify() the same, but have something like the below code in Message.detail()

        obj = sy.serde.msgpack.serde._detail(worker, msg_tuple[0])
        if isinstance(obj, Message):
            return obj
        return Message(obj)

Let me know your thoughts.

[PlamenHristov]

Ok I can see those methods will be deleted #2826. Nvm.

[karlhigley]

@PlamenHristov #2826 won't be merged, so I think this is still relevant.

[github-actions]

This issue has been marked stale because it has been open 30 days with no activity. Leave a comment or remove the stale label to unmark it. Otherwise, this will be closed in 7 days.