Rework Plans/Procedures to store non-simplified Operation objects#2883
Closed
karlhigley wants to merge 10 commits intoOpenMined:masterfrom
Closed
Rework Plans/Procedures to store non-simplified Operation objects#2883karlhigley wants to merge 10 commits intoOpenMined:masterfrom
karlhigley wants to merge 10 commits intoOpenMined:masterfrom
Conversation
The structure output by the msgpack serialization has changed since this test was written, so this updates the structure in order to allow it to be detailed back into Python objects.
karlhigley
force-pushed
the
refactor/plan-operations
branch
from
395dbd0 to
fbdcc2d
Compare
karlhigley
added
Type: Refactor 🔨
LaRiffle
reviewed
Jan 13, 2020
| if owner.id in from_ids: | ||
| owner.id = to_ids[from_ids.index(owner.id)] | ||
|
|
||
| if owner.id_at_location in from_ids: |
Contributor
There was a problem hiding this comment.
I think owner have no id_at_location
Contributor
Author
There was a problem hiding this comment.
The owner can be a PointerTensor, so it can have an id_at_location property, but may not always. As written, this code may fail with non-pointer tensors. 🤔
LaRiffle
reviewed
Jan 13, 2020
| operation, from_ids_simplified, to_ids_simplified | ||
| ) | ||
| # replace ids in the owner | ||
| owner = operation.cmd_owner |
Contributor
There was a problem hiding this comment.
What is the type of operation now? I can't find the definition here it must be in the unchanged files
Contributor
Author
There was a problem hiding this comment.
It's an Operation object.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make it easier to serialize them to multiple formats (like msgpack and Protobuf.)