Migrate CI tests to Github Actions

.github/workflows/run-tests.yml

@@ -0,0 +1,60 @@
+name: Run tests
+
+on:
+  push:
+    branches:
+    - master
+  pull_request:
+    types: [opened, synchronize, reopened]
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+    strategy:
+      max-parallel: 4
+      matrix:
+        python-version: [3.6, 3.7]
+
+    steps:
+    - uses: actions/checkout@v1
+    - name: Set up Python ${{ matrix.python-version }}
+      uses: actions/setup-python@v1
+      with:
+        python-version: ${{ matrix.python-version }}
+    - name: Install dependencies
+      run: |
+        sudo apt-get update
+        python -m pip install --upgrade pip
+        hash -r
+        pip3 install -r pip-dep/requirements.txt
+        pip3 install -r pip-dep/requirements_dev.txt
+        pip3 install -r pip-dep/requirements_udacity.txt
+        pip3 install -r pip-dep/requirements_notebooks.txt
+        pip3 install scikit-learn
+        python setup.py install
+    - name: Lint, format, and type-check
+      run: |
+        pip3 install flake8
+        #- pip3 install flake8-docstrings
+        pip3 install flake8-comprehensions
+        pip3 install pep8-naming
+        # stop the build if there are Python syntax errors or undefined names
+        flake8 --config=.flake8 .
+        black --check --verbose .
+        # exit-zero treats all errors as warnings.
+        # diverting from the standard 79 character line length in
+        # accordance with this:
+        # https://www.python.org/dev/peps/pep-0008/#a-foolish-consistency-is-the-hobgoblin-of-little-minds
+        flake8 . --count --exit-zero --statistics --select=E,F,W,C90
+        # Run type checker in CI such that type errors can be identified and gradually addressed.
+        # Once all existing type errors are addressed, the `|| echo` after the mypy call can be removed.
+        mypy syft || echo "Type errors found, continuing build..."
+    - name: Test with pytest
+      run: |
+        coverage run -m pytest test --deselect=test/notebooks/test_notebooks.py::test_notebooks_basic_translations --deselect=test/notebooks/test_notebooks.py::test_all_translation_notebooks --deselect=test/efficiency
+    - name: Coverage reports
+      run: |
+        coverage report --ignore-errors --fail-under 95 -m
+        # ensuring coverage of tests stays at 100 until entire coverage can be 100
+        coverage report --ignore-errors --fail-under 100 -m --include="test/*"

.github/workflows/run-translation-tests.yml

@@ -0,0 +1,36 @@
+name: Run notebook translation tests
+
+on:
+  push:
+    paths:
+    - 'examples/tutorials/**'
+
+jobs:
+  build:
+
+    runs-on: ubuntu-latest
+    strategy:
+      max-parallel: 4
+      matrix:
+        python-version: [3.6, 3.7]
+
+    steps:
+    - uses: actions/checkout@v1
+    - name: Set up Python ${{ matrix.python-version }}
+      uses: actions/setup-python@v1
+      with:
+        python-version: ${{ matrix.python-version }}
+    - name: Install dependencies
+      run: |
+        sudo apt-get update
+        python -m pip install --upgrade pip
+        hash -r
+        pip3 install -r pip-dep/requirements.txt
+        pip3 install -r pip-dep/requirements_dev.txt
+        pip3 install -r pip-dep/requirements_udacity.txt
+        pip3 install -r pip-dep/requirements_notebooks.txt
+        pip3 install scikit-learn
+        python setup.py install
+    - name: Test with pytest
+      run: |
+        pytest test test/notebooks/test_notebooks.py::test_notebooks_basic_translations

.travis.yml

@@ -40,7 +40,7 @@ before_script:
   - mypy syft || echo "Type errors found, continuing build..."
 script:
   - coverage run -m pytest test
-  - coverage report --omit="syft/grid/*","syft/frameworks/torch/nn/rnn.py" --ignore-errors --fail-under 95 -m
+  - coverage report --ignore-errors --fail-under 95 -m
   # ensuring coverage of tests stays at 100 until entire coverage can be 100
   - coverage report --ignore-errors --fail-under 100 -m --include="test/*"
   # - bash scripts/execute_notebooks.sh

setup.cfg

@@ -20,7 +20,11 @@ omit =
 	*/venv/*
 	setup.py
 	.eggs/*
+	.github/*
 	*__init__.py
 	*tf_encrypted*
+	syft/grid/*
+	syft/frameworks/torch/nn/rnn.py
 	syft/workers/websocket_server.py
+	test/efficiency/*
 

test/efficiency_tests/test_activations_time.py → test/efficiency/test_activations_time.py

@@ -1,7 +1,7 @@
 import pytest
 import torch
 import syft as sy
-from test.efficiency_tests.assertions import assert_time
+from test.efficiency.assertions import assert_time
 
 
 @pytest.mark.parametrize("activation", ["tanh", "sigmoid"])

test/efficiency_tests/test_linalg_time.py → test/efficiency/test_linalg_time.py

@@ -3,7 +3,7 @@
 import syft as sy
 from syft.frameworks.torch.linalg import inv_sym
 from syft.frameworks.torch.linalg.operations import _norm_mpc
-from test.efficiency_tests.assertions import assert_time
+from test.efficiency.assertions import assert_time
 
 
 @assert_time(max_time=40)

test/notebooks/test_notebooks.py

@@ -84,7 +84,7 @@ def test_notebooks_basic(isolated_filesystem, notebook):
 @pytest.mark.parametrize(
     "translated_notebook", sorted(set(translated_notebooks) - set(excluded_notebooks))
 )
-def test_notebooks_basic_translations(isolated_filesystem, translated_notebook):
+def test_notebooks_basic_translations(isolated_filesystem, translated_notebook):  # pragma: no cover
     """Test Notebooks in the tutorial translations folder."""
     notebook = "/".join(translated_notebook.split("/")[-2:])
     notebook = f"translations/{notebook}"
@@ -174,11 +174,6 @@ def test_fl_with_websockets_and_averaging(
 
 
 ### These tests must always be last
-def test_all_non_excluded_notebooks():
-    untested_notebooks = set(all_notebooks) - set(excluded_notebooks) - set(tested_notebooks)
-    assert len(untested_notebooks) == 0, untested_notebooks
-
-
 def test_all_notebooks_except_translations():
     untested_notebooks = (
         set(all_notebooks)
@@ -187,3 +182,8 @@ def test_all_notebooks_except_translations():
         - set(tested_notebooks)
     )
     assert len(untested_notebooks) == 0, untested_notebooks
+
+
+def test_all_translation_notebooks():  # pragma: no cover
+    untested_notebooks = set(translated_notebooks) - set(excluded_notebooks) - set(tested_notebooks)
+    assert len(untested_notebooks) == 0, untested_notebooks

test/torch/linalg/test_operations.py

@@ -5,7 +5,6 @@
 from syft.frameworks.torch.linalg import qr
 from syft.frameworks.torch.linalg.operations import _norm_mpc
 from syft.frameworks.torch.linalg.lr import DASH
-from test.efficiency_tests.assertions import assert_time
 
 
 def test_inv_sym(hook, workers):
@@ -31,7 +30,6 @@ def test_inv_sym(hook, workers):
     assert (diff < 1e-3).all()
 
 
-@assert_time(max_time=20)
 def test_norm_mpc(hook, workers):
     """
     Testing computation of vector norm on an AdditiveSharedTensor

test/torch/tensors/test_precision.py

@@ -3,7 +3,6 @@
 import torch.nn as nn
 import torch.nn.functional as F
 
-from test.efficiency_tests.assertions import assert_time
 from syft.frameworks.torch.tensors.interpreters.precision import FixedPrecisionTensor
 
 
@@ -388,7 +387,6 @@ def test_torch_dot(workers):
     assert torch.dot(x, y).float_prec() == 45
 
 
-@assert_time(max_time=6)
 def test_torch_inverse_approx(workers):
     """
     Test the approximate inverse with different tolerance depending on
@@ -416,7 +414,6 @@ def test_torch_inverse_approx(workers):
             assert (diff / (tolerance * norm)) < 1
 
 
-@assert_time(max_time=10)
 def test_torch_exp_approx(workers):
     """
     Test the approximate exponential with different tolerance depending on
@@ -444,7 +441,6 @@ def test_torch_exp_approx(workers):
         assert (cumsum < 1).all()
 
 
-@assert_time(max_time=40)
 def test_torch_sigmoid_approx(workers):
     """
     Test the approximate sigmoid with different tolerance depending on
@@ -472,7 +468,6 @@ def test_torch_sigmoid_approx(workers):
             assert (diff / (tolerance * norm)) < 1
 
 
-@assert_time(max_time=45)
 def test_torch_log_approx(workers):
     """
     Test the approximate logarithm with different tolerance depending on