Skip to content

Bengali Tutorial Part One#2938

Merged
karlhigley merged 8 commits intoOpenMined:masterfrom
ucalyptus:bengali-tutorial-1
Jan 22, 2020
Merged

Bengali Tutorial Part One#2938
karlhigley merged 8 commits intoOpenMined:masterfrom
ucalyptus:bengali-tutorial-1

Conversation

@ucalyptus
Copy link
Contributor

About Bengali
With approximately 228 million native speakers and another 37 million as second language speakers, Bengali is the fifth most-spoken native language and the seventh most spoken language by total number of speakers in the world.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

Copy link
Contributor

@karlhigley karlhigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and I'll be happy to merge it! Just want to request one small change: add a section for "translators" below the "authors" section, and list yourself there. 😄

@ucalyptus
Copy link
Contributor Author

@karlhigley noted. making changes.

@ucalyptus ucalyptus closed this Jan 21, 2020
@ucalyptus ucalyptus reopened this Jan 21, 2020
@ucalyptus
Copy link
Contributor Author

@karlhigley changes made, awaiting CI build to finish

@ucalyptus
Copy link
Contributor Author

@karlhigley Also check #2942

@ucalyptus ucalyptus changed the title Uploading Bengali Part One Bengali Tutorial Part One Jan 21, 2020
@@ -0,0 +1,642 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • In other languages, we've been putting the translators section below the "Authors" section. I think it should go right under "লেখক: Andrew Trask - Twitter: @iamtrask"


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. missed that. redoing it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed it

@ucalyptus ucalyptus closed this Jan 21, 2020
@ucalyptus ucalyptus reopened this Jan 21, 2020
@ucalyptus ucalyptus closed this Jan 21, 2020
@ucalyptus ucalyptus reopened this Jan 21, 2020
@ucalyptus ucalyptus requested a review from karlhigley January 21, 2020 17:25
@ucalyptus ucalyptus closed this Jan 21, 2020
@ucalyptus ucalyptus reopened this Jan 21, 2020
@ucalyptus ucalyptus closed this Jan 21, 2020
@ucalyptus ucalyptus reopened this Jan 21, 2020
@ucalyptus
Copy link
Contributor Author

@karlhigley changes made. Added the Translator section right after Authors both here and in #2942

@karlhigley karlhigley merged commit b61134c into OpenMined:master Jan 22, 2020
@karlhigley
Copy link
Contributor

@ucalyptus Thanks for the translations!

@ucalyptus
Copy link
Contributor Author

@karlhigley Thanks for merging. All of the notebooks to come soon in Bengali

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants