Skip to content

Perform direct summation in handcrafted layers#2945

Merged
LaRiffle merged 3 commits intoOpenMined:masterfrom
arshjot:handcrafted-layers
Jan 22, 2020
Merged

Perform direct summation in handcrafted layers#2945
LaRiffle merged 3 commits intoOpenMined:masterfrom
arshjot:handcrafted-layers

Conversation

@arshjot
Copy link
Contributor

@arshjot arshjot commented Jan 21, 2020

Solves #2927, also modifies the test for handcrafted pooling layer to check for exact match

Copy link
Contributor

@LaRiffle LaRiffle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks!

@LaRiffle LaRiffle merged commit 2f63eb0 into OpenMined:master Jan 22, 2020
@arshjot arshjot deleted the handcrafted-layers branch January 26, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants