Send & Get Datasets#2960
Merged
karlhigley merged 44 commits intoOpenMined:masterfrom Mar 16, 2020
abogaziah:master
Merged
Conversation
LaRiffle
suggested changes
Jan 24, 2020
Contributor
LaRiffle
left a comment
LaRiffle
left a comment
There was a problem hiding this comment.
Add a small test and we're good
LaRiffle
suggested changes
Jan 25, 2020
syft/frameworks/torch/fl/dataset.py
Outdated
| owner=None, | ||
| tags: List[str] = None, | ||
| description: str = None, | ||
| child=None, |
Contributor
There was a problem hiding this comment.
for conciseness just put **kwargs and report them in super().__init__(**kwargs)
LaRiffle
previously approved these changes
Jan 26, 2020
LaRiffle
suggested changes
Feb 19, 2020
Contributor
LaRiffle
left a comment
LaRiffle
left a comment
There was a problem hiding this comment.
Great job and thanks for the tests! :)
One last question left
syft/workers/base.py
Outdated
| # for a tensor we don't own, then it's probably someone else's | ||
| # decision to decide when to delete the tensor. | ||
| ptr = obj.create_pointer(garbage_collect_data=False, owner=sy.local_worker).wrap() | ||
| ptr = obj.create_pointer(garbage_collect_data=False, owner=sy.local_worker, location=self).wrap() |
Contributor
There was a problem hiding this comment.
Why did you need to change this location argument?
Member
Author
There was a problem hiding this comment.
because if the location wasn't passed it would assume the location is the local worker, which isn't correct. the search result would be always: (me | id -> me | id_at_location) instead of (me | id -> location | id_at_location)
LaRiffle
approved these changes
Feb 23, 2020
Contributor
LaRiffle
left a comment
LaRiffle
left a comment
There was a problem hiding this comment.
Let’s fix the last tests and merge it!
Closed
karlhigley
approved these changes
Mar 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
first milestone in the issue #2670