Fix broken asynchronous federated learning tutorial#3048
Merged
Conversation
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
LaRiffle
reviewed
Feb 13, 2020
midokura-silvia
force-pushed
the
fix-async-tutorial
branch
from
e79d1f2 to
200da04
Compare
midokura-silvia
force-pushed
the
fix-async-tutorial
branch
2 times, most recently
from
21cbcb5 to
5b4732a
Compare
midokura-silvia
force-pushed
the
fix-async-tutorial
branch
from
19eaf07 to
74b4a16
Compare
LaRiffle
approved these changes
Mar 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The methods federated_client.evalute() and federated_client.async_fit() are now called via the new Baseworker.execute_worker_function() function. Before it relied on Baseworker.execute_command() whose behaviour changed and is meant to be used for Tensor functions only.
The pullrequest needs a modification in syft-proto.