Skip to content

Add Bengali Translated Notebooks Part 9 & 10#3050

Merged
karlhigley merged 7 commits intomasterfrom
unknown repository
Feb 24, 2020
Merged

Add Bengali Translated Notebooks Part 9 & 10#3050
karlhigley merged 7 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Feb 12, 2020

Translated Notebook:

Part 09 - Intro to Encrypted Programs.ipynb

Translated Notebook:

Part 10 - Federated Learning with Secure Aggregation.ipynb
Translated Notebook:

Part 09 - Intro to Encrypted Programs.ipynb
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@ucalyptus
Copy link
Contributor

@adventuroussrv @karlhigley any insights on why the tutorials CI is failing for all PRs related to translations?
Close look at the CI trace suggests pytest errors.

@karlhigley
Copy link
Contributor

The translation test suite is now taking too long again after so many translations have been added. It probably needs to be split apart into separate actions per language.

@karlhigley
Copy link
Contributor

@ucalyptus Translation test issues seem to be resolved. Could you give this a review?

@ghost ghost mentioned this pull request Feb 20, 2020
17 tasks
@ucalyptus
Copy link
Contributor

@adventuroussrv request a review from me and karl . same for #3049

@ghost
Copy link
Author

ghost commented Feb 20, 2020

Hi @ucalyptus! You are already requested to review the PR #3049 by Karl!

Copy link
Contributor

@ucalyptus ucalyptus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karlhigley karlhigley merged commit 15a0609 into OpenMined:master Feb 24, 2020
@ghost ghost changed the title Add Bengali Translated Notebooks #Part 9 Add Bengali Translated Notebooks Part 9 & 10 Feb 24, 2020
@ghost
Copy link
Author

ghost commented Feb 24, 2020

Thanks for the review @ucalyptus :)

@ghost
Copy link
Author

ghost commented Feb 24, 2020

Yaaaaaaay! Thanks a lot @karlhigley 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants