Only test translation notebooks if they have been changed#3064
Merged
karlhigley merged 4 commits intoOpenMined:masterfrom Feb 21, 2020
Merged
Only test translation notebooks if they have been changed#3064karlhigley merged 4 commits intoOpenMined:masterfrom
karlhigley merged 4 commits intoOpenMined:masterfrom
Conversation
karlhigley
added
Type: Refactor 🔨
nph4rd
force-pushed
the
fix-translation-tests
branch
from
9987d61 to
8f51113
Compare
nph4rd
force-pushed
the
fix-translation-tests
branch
from
b0e392a to
2c7f764
Compare
karlhigley
approved these changes
Feb 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3060 - Second try.
Solves the same problem as #3059 but only tests the notebooks if they have actually been changed.
The following command changed:
git diff --name-only origin/${{ github.base_ref }} examples/tutorials/translations/ > ./test/notebooks/git-diff.txtHopefully that will do the job.