Add and refine document#3120
Conversation
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
|
Reformat done, ready to merge. |
|
|
||
| assert key in fed_client.datasets | ||
|
|
||
| # remove new dataset |
There was a problem hiding this comment.
Could you use 'R' in place of 'r' such that it follows the same pattern as the above comment ("Create a dataset")
| # Create a dataset | ||
| dataset = "my_dataset" | ||
| key = "string_dataset" | ||
| # add new dataset |
There was a problem hiding this comment.
Could you use 'A' in place of 'a' such that it follows the same pattern as the above comment ("Create a dataset")
|
|
||
| assert "string_dataset" in fed_client.datasets | ||
|
|
||
| # Raise error if the key is already exists |
| dataset = "my_dataset" | ||
| fed_client.add_dataset(dataset, "string_dataset") | ||
| key = "string_dataset" | ||
| # add new dataset |
There was a problem hiding this comment.
Could you use 'A' in place of 'a' such that it is the same as above?
| dataset = "my_dataset" | ||
| fed_client.add_dataset(dataset, "string_dataset") | ||
| key = "string_dataset" | ||
| # add new dataset |
There was a problem hiding this comment.
Could you use 'A' in place of 'a' such that it is the same as above (with big "C")?
syft/workers/virtual.py
Outdated
| if self.message_pending_time > 0: | ||
| if self.verbose: | ||
| print(f"pending time of {self.message_pending_time} seconds to send message...") | ||
| # pending |
There was a problem hiding this comment.
Q: Maybe remove this comment - I think the attribute name is self-explanatory.
|
LGTM |
2 participants
This PR makes a contribution to #2510