Skip to content

Add Bengali Translated Notebooks #Part 4 and #Part 5#3121

Merged
karlhigley merged 6 commits intoOpenMined:masterfrom
jabertuhin:bengali-translation
Mar 3, 2020
Merged

Add Bengali Translated Notebooks #Part 4 and #Part 5#3121
karlhigley merged 6 commits intoOpenMined:masterfrom
jabertuhin:bengali-translation

Conversation

@jabertuhin
Copy link
Contributor

Translated Notebooks:

  • Part 04 - Federated Learning via Trusted Aggregator.ipynb

  • Part 05 - Welcome to the Sandbox.ipynb

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@jabertuhin jabertuhin mentioned this pull request Feb 29, 2020
17 tasks
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jabertuhin
Copy link
Contributor Author

Hi, @adventuroussrv
Is there anything that I can fix to pass the tests?

@karlhigley
Copy link
Contributor

@jabertuhin I think this just needs to merge in the latest commits from the master branch.

@jabertuhin
Copy link
Contributor Author

@karlhigley my branch is up-to-date with the upstream/master branch.
git merge upstream/master
Already up to date.
Can there be any other thing or I am missing something?

@karlhigley
Copy link
Contributor

Maybe you hadn't pushed the update yet? It was behind master a bit. Anyway, merged in master and we'll see if that fixes the tests.

@jabertuhin
Copy link
Contributor Author

@karlhigley It's fine now.

@karlhigley karlhigley merged commit 811f3ec into OpenMined:master Mar 3, 2020
@ghost
Copy link

ghost commented Mar 3, 2020

Congrats! @jabertuhin 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants