Skip to content

added FLOptimizer class#3187

Closed
ratmcu wants to merge 7 commits intoOpenMined:masterfrom
ratmcu:master
Closed

added FLOptimizer class#3187
ratmcu wants to merge 7 commits intoOpenMined:masterfrom
ratmcu:master

Conversation

@ratmcu
Copy link
Contributor

@ratmcu ratmcu commented Mar 12, 2020

FLOptimizer that can maintain a optimizer per worker internally.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@ratmcu ratmcu closed this Mar 12, 2020
@ratmcu ratmcu reopened this Mar 12, 2020
@ratmcu ratmcu marked this pull request as ready for review March 13, 2020 01:20
@ratmcu
Copy link
Contributor Author

ratmcu commented Mar 13, 2020

@iamtrask I added the class and Changed the Notebook to use it.
3.7 Tutorials are failing here on the test
test/notebooks/test_notebooks.py::test_notebooks_basic[examples/tutorials/Part 12 bis - Encrypted Training on MNIST.ipynb] FAILED [ 52%]

@karlhigley
Copy link
Contributor

Duplicate of #3179. Might be worth reviewing #3179 and checking if there aspects from this PR that could be added to that code.

@karlhigley karlhigley closed this Mar 15, 2020
@ratmcu
Copy link
Contributor Author

ratmcu commented Mar 15, 2020

@karlhigley , I created this class for arbitrarily creating or calling an optimizer relevant to a model trained in a federated setting. I would like to add any good features from it to the code base with further developments if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants