Standardize the names of tensor, plan, and worker command messages#3198
Merged
karlhigley merged 6 commits intoOpenMined:masterfrom Mar 16, 2020
Merged
Standardize the names of tensor, plan, and worker command messages#3198karlhigley merged 6 commits intoOpenMined:masterfrom
karlhigley merged 6 commits intoOpenMined:masterfrom
Conversation
karlhigley
added
the
Type: Refactor 🔨
Jasopaum
approved these changes
Mar 15, 2020
Member
Jasopaum
left a comment
Jasopaum
left a comment
There was a problem hiding this comment.
After having read it again, I'm not sure these types of messages are really handled differently (see execute_worker_function, execute_plan_command, and execute_computation).
Otherwise, I'm ok with the naming changes.
Contributor
Author
|
Yeah, I'm not so sure either. Possible that they could share an underlying implementation? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on OpenMined/syft-proto#53.