Skip to content

Move Placeholder class to execution package#3211

Merged
LaRiffle merged 3 commits intoOpenMined:masterfrom
karlhigley:refactor/placeholder-pkg
Mar 18, 2020
Merged

Move Placeholder class to execution package#3211
LaRiffle merged 3 commits intoOpenMined:masterfrom
karlhigley:refactor/placeholder-pkg

Conversation

@karlhigley
Copy link
Contributor

It's not actually specific to PyTorch and is most closely related to
the other classes in execution (e.g. Plans, Protocols.)

It's not actually specific to PyTorch and is most closely related to
the other classes in `execution` (e.g. `Plans`, `Protocols`.)
@karlhigley karlhigley requested a review from a team March 17, 2020 17:54
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@karlhigley karlhigley added plans Type: Refactor 🔨 A complete overhaul of a file, feature, or codebase labels Mar 17, 2020
Copy link
Contributor

@LaRiffle LaRiffle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great decision :)

Copy link
Member

@Jasopaum Jasopaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LaRiffle LaRiffle merged commit 784cd9d into OpenMined:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Refactor 🔨 A complete overhaul of a file, feature, or codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants