Skip to content

OpenTelemetry #2#8968

Merged
yashgorana merged 28 commits intodevfrom
yash/tracing2
Sep 2, 2024
Merged

OpenTelemetry #2#8968
yashgorana merged 28 commits intodevfrom
yash/tracing2

Conversation

@yashgorana
Copy link
Contributor

Description

OpenTelemetry

Syft Backend

  • Update OTel packages
  • Add OTel auto-instrumentation (programmatic instead of opentelemetry-instrument root proc)
    • fastapi
    • pymongo
    • botocore
  • Fix OTel exporter (Jaeger --> OTLP)
  • Fix OTel Spans (remove @instrument from classes, @service_methods are always instrumented)
  • Custom workers (in-progress)
    • Plumb OTEL_SERVICE_NAME, OTEL_EXPORTER_* env vars to worker pool launch
  • ZMQ tracing (in-progress)
    • instrument zmq messages except heartbeat
    • zmq messages need to include OTLP span for it to be picked up by the consumer (like Traceparent header)

Syft Client

  • Add OTel span to Syft Client (todo. a trace should capture client -> backend ->worker -> db)
    • Include requests auto-instrumenter
    • Client needs an API endpoint to export client traces to backend.
  • Backend uses syft client, in this case we need to export directly to internal provider (???)

Infra

  • Dev - UI (tox -re dev.k8s.install.signoz)
  • OTel operator

Affected Dependencies

List any dependencies that are required for this change.

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

@yashgorana yashgorana self-assigned this Jun 25, 2024
@yashgorana yashgorana mentioned this pull request Jun 25, 2024
15 tasks
@Smartappli Smartappli mentioned this pull request Jun 26, 2024
4 tasks
@madhavajay madhavajay self-requested a review September 2, 2024 11:18
Copy link
Collaborator

@madhavajay madhavajay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🙌

@yashgorana yashgorana merged commit 3e8b3b3 into dev Sep 2, 2024
@yashgorana yashgorana deleted the yash/tracing2 branch September 2, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants