Refactor DB as document store, add Postgres, remove mongo#9176
Merged
Refactor DB as document store, add Postgres, remove mongo#9176
Conversation
… into eelco/json_action_store
… into eelco/json_action_store
| try: | ||
| value = getattr(obj, attr) | ||
| except Exception as e: | ||
| if raise_errors: |
Collaborator
There was a problem hiding this comment.
when would you not want to do this?
Contributor
Author
There was a problem hiding this comment.
searchable attrs can be @property methods, and those can throw errors. Example: Job.code_id was throwing errors when the Job was for a twinAPI. This flag is to control this behaviour, 'do i want to skip writing if some method throws an error'
we're using raise_errors=False right now to just skip searchable properties that hit an exception
- redefine migrations for queue items and subclasses
koenvanderveen
approved these changes
Sep 16, 2024
koenvanderveen
changed the title
- add migration method for notification class
…k8s to `tmp/data/db` Co-authored-by: Shubham Gupta <shubhamgupta3121@gmail.com>
shubham3121
reviewed
Sep 16, 2024
This reverts commit 8417653.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change, the motivation, and any additional context that will help others understand your PR. If it closes one or more open issues, please tag them as described here.
Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist